Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fluentd-gcp version #45892

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Update fluentd-gcp version #45892

merged 1 commit into from
Jun 1, 2017

Conversation

crassirostris
Copy link

@crassirostris crassirostris commented May 16, 2017 •
edited

Updates the fluent-plugin-google-cloud version to 0.6.3. This patch containes bug fixes

@crassirostris crassirostris added area/logging needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. retest-not-required labels May 16, 2017
@crassirostris crassirostris added this to the v1.7 milestone May 16, 2017
@crassirostris crassirostris requested a review from piosz May 16, 2017 14:53
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 16, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2017
@crassirostris crassirostris added cherrypick-candidate and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2017
@crassirostris crassirostris mentioned this pull request May 16, 2017
Closed
@piosz
Copy link
Member

piosz commented May 17, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, piosz

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@piosz
Copy link
Member

piosz commented May 17, 2017

@k8s-bot gce etcd3 e2e test this

1 similar comment
@crassirostris
Copy link
Author

@k8s-bot gce etcd3 e2e test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 17, 2017 •
edited

@crassirostris: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GCE etcd3 e2e 9c32b8b9b24c970a079dc00890a4960fca1104cc link @k8s-bot gce etcd3 e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crassirostris
Copy link
Author

@piosz @igorpeshansky Turns out new google cloud output plugin has a regression, it doesn't specify namespace name and pod name in the exported resource and that's why tests are failing

@crassirostris crassirostris mentioned this pull request May 31, 2017
Merged
@crassirostris crassirostris removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 1, 2017
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@igorpeshansky
Copy link

For the record, the regression @crassirostris mentioned is fixed in version 0.6.3.

@crassirostris
Copy link
Author

Yes, thanks to @igorpeshansky and @qingling128 for a quick fix!

@crassirostris
Copy link
Author

Since the only change since lgtm is v2.0.3 -> v2.0.4 and the point of this PR hasn't changed, re-applying the lgtm label from #45892 (comment)

@crassirostris crassirostris added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b7f52a8 into kubernetes:master Jun 1, 2017
This was referenced Jun 1, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piosz piosz Awaiting requested review from piosz

Assignees

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@crassirostris @piosz @k8s-github-robot @k8s-ci-robot @igorpeshansky @dchen1107